You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds accessible labels and titles to a few obvious icon only controls in the sidebar/chat UI.This is intended as a small first pass improvement for screen reader support. It does not try to solve the full sidebar accessibility issue in one PR.
Testing
Ran npm.cmd run lint --prefix gui
Ran git diff --check
Notes
I kept the scope focused on controls where the action was clear from the existing UI.
Summary by cubic
Adds accessible labels and titles to sidebar/chat controls and labels the main chat input for screen readers. Addresses #12325 by clearly labeling close, send, configure, and the chat input.
Bug Fixes
FindWidget: add "Close find widget" aria-label and title to the close button.
InputToolbar: add "Send message" aria-label and title to the submit button.
ModelSelect: add "Configure " to per-option cog and "Configure models" to the toolbar cog.
HeaderButtonWithToolTip: set aria-label and title from the text prop for icon-only header buttons.
It looks like PR Checks / jetbrains-tests failed, but this PR only changes GUI accessibility attributes in React components.I’m checking the logs now. If this is unrelated, would it be possible to rerun that check?
Hmph the failing check is PR Checks / jetbrains-tests, specifically Autocomplete > testAutocomplete() in the JetBrains integration suite.This PR only adds aria-label / title attributes to GUI React components and does not touch the JetBrains extension or autocomplete code, so this looks unrelated to the patch.
Hey, great work. Can I make one request for this pr and thats if you could label the input box. I'll make a new issue now for the message history. Thanks!
@paul-geoghegan Added the input box label in the latest commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #12325
Summary
Adds accessible labels and titles to a few obvious icon only controls in the sidebar/chat UI.This is intended as a small first pass improvement for screen reader support. It does not try to solve the full sidebar accessibility issue in one PR.
Testing
npm.cmd run lint --prefix guigit diff --checkNotes
I kept the scope focused on controls where the action was clear from the existing UI.
Summary by cubic
Adds accessible labels and titles to sidebar/chat controls and labels the main chat input for screen readers. Addresses #12325 by clearly labeling close, send, configure, and the chat input.
textprop for icon-only header buttons.Written for commit 0b3ac42. Summary will update on new commits.